Opened 16 years ago
Closed 16 years ago
#157 closed defect (fixed)
Generalize functionality of CarController.reset()
Reported by: | Henrik Heimbuerger | Owned by: | Florian Roth |
---|---|---|---|
Priority: | major | Milestone: | MS1: First release (1.0.0) |
Component: | controller | Version: | pre-1.0 |
Keywords: | reset, deactivate, activate, carcontroller | Cc: |
Description
Shouldn't CarController.reset() also be called when the race is started (or stopped)? Right now, most controllers will probably have to duplicate the functionality of reset() in their activate() or deactivate() method.
Also, reset(), as a very central interface method, desperately needs an extensive javadoc that describes exactly when it is called, when it is not called and what behaviour is expected from implementors.
Change History (3)
comment:1 Changed 16 years ago by
Status: | new → assigned |
---|
comment:2 Changed 16 years ago by
comment:3 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed see javadoc in CarController?.reset()
Note: See
TracTickets for help on using
tickets.
New commit by froth (revision [456]):
[Fix for ticket #152,#157,#149] fixed starting point problem on reset, generalized functionality on CarController?.reset().
Now reset functionality etc. is back in the RaceEngine? so we have a better workflow and TDA's have a bit less functionality. This was reached to give the TDA an reset function to reset saved speed and acceleration if car crashes. I think its good and fine if all race workflow logic is generalized in the RaceEngine? so the TDA only has to approximate position by physics etc. Maybe we can outsource functionality currently in TrackDataApproximator? like calculation of steps between checkpoints later some where in a TrackDataInformationManager? initialized by RaceEngine? before raceStart so TDA can get its information about track etc concentrated from TrackDataInformationManager? because currently intelligence informations about the track are not easy to get.
We need a reset on CarController? because the deactivate function disables the Controller listeners for example keyboard lsiteners so a reset push button could not be detected further the RaceEngine? couldnt trigger the ControlerSignal?.isReset()and the car is out of race for ever. Added javadoc to CarController? reset().