Opened 16 years ago

Closed 16 years ago

#149 closed defect (fixed)

Do [416] again and this time right :)

Reported by: Henrik Heimbuerger Owned by: Henrik Heimbuerger
Priority: major Milestone: MS1: First release (1.0.0)
Component: racelogic Version: pre-1.0
Keywords: Cc:

Description

Change [416] is incorrect. The laneIndex is not the same as the starting point index. For example, on the current digital track, starting points 0 and 2 are both on lane 1.
Correspondingly, there may be future tilesets with two starting points but four lanes. So the code will crash for lane 2, because there is no starting point 2.

Change History (7)

comment:1 Changed 16 years ago by Henrik Heimbuerger

Owner: changed from nobody to Florian Roth
Status: newassigned

comment:2 Changed 16 years ago by Henrik Heimbuerger

Summary: Do [416] again and this time rightDo [416] again and this time right :)

comment:3 Changed 16 years ago by SVN

New commit by froth (revision [456]):
[Fix for ticket #152,#157,#149] fixed starting point problem on reset, generalized functionality on CarController?.reset().

Now reset functionality etc. is back in the RaceEngine? so we have a better workflow and TDA's have a bit less functionality. This was reached to give the TDA an reset function to reset saved speed and acceleration if car crashes. I think its good and fine if all race workflow logic is generalized in the RaceEngine? so the TDA only has to approximate position by physics etc. Maybe we can outsource functionality currently in TrackDataApproximator? like calculation of steps between checkpoints later some where in a TrackDataInformationManager? initialized by RaceEngine? before raceStart so TDA can get its information about track etc concentrated from TrackDataInformationManager? because currently intelligence informations about the track are not easy to get.

We need a reset on CarController? because the deactivate function disables the Controller listeners for example keyboard lsiteners so a reset push button could not be detected further the RaceEngine? couldnt trigger the ControlerSignal?.isReset()and the car is out of race for ever. Added javadoc to CarController? reset().

comment:4 Changed 16 years ago by Florian Roth

Owner: changed from Florian Roth to Henrik Heimbuerger

Please Test. Should be fixed

comment:5 Changed 16 years ago by Henrik Heimbuerger

Status: assignedaccepted

comment:6 Changed 16 years ago by SVN

New commit by hheimbuerger (revision [459]):
[Partial fix for ticket #149] Proof-read the CarController?.reset() javadoc.

comment:7 Changed 16 years ago by Henrik Heimbuerger

Resolution: fixed
Status: acceptedclosed

Together with [496], I think this should be fine now. But it's also listed for testing again in #167.

Note: See TracTickets for help on using tickets.