Opened 16 years ago

Closed 16 years ago

#114 closed defect (fixed)

Change the way RaceEngine handles switch trigger signals

Reported by: Florian Roth Owned by: Florian Roth
Priority: blocker Milestone: MS1: First release (1.0.0)
Component: controller Version: pre-1.0
Keywords: Cc:

Description

see also #109

Change History (10)

comment:1 in reply to:  description Changed 16 years ago by Florian Roth

Replying to froth:

see also #109

comment:2 Changed 16 years ago by SVN

New commit by froth (revision [333]):
[Fix for ticket #114] fixed the double trigger problem on KeyboardDevice?

the problem was that there were two listeners added KeyUp? and KeyDown? we only need key Down

comment:3 Changed 16 years ago by Florian Roth

Resolution: fixed
Status: newclosed

comment:4 Changed 16 years ago by Henrik Heimbuerger

Resolution: fixed
Status: closedreopened

comment:5 Changed 16 years ago by SVN

New commit by hheimbuerger (revision [356]):
[Partial fix for ticket #114] Fixed broken trigger support in the KeyboardDevice?.

The trigger actually does need the KeyUp? event (which was removed in [333]) to detect whether the trigger is currently held.

comment:6 Changed 16 years ago by Henrik Heimbuerger

Owner: changed from nobody to Florian Roth
Status: reopenedassigned

Please review my modifications, as I don't quite understand everything in KeyboardDevice.

Also, is it really necessary to duplicate the ControllerSignal in poll()?

comment:7 Changed 16 years ago by Henrik Heimbuerger

Priority: minorblocker

This currently prevents lane changes using the keyboard.

comment:8 Changed 16 years ago by Florian Roth

Summary: The key Up and down event in KeyboardDevice is triggered two timesChange the way RaceEngine handles switch trigger signals

I tested Wiimote, Mouse and Keyboard all works fine for me. see next changeset

comment:9 Changed 16 years ago by SVN

New commit by froth (revision [367]):
[Related to ticket#114] changed the way RaceEngine? handles switch trigger

comment:10 Changed 16 years ago by Florian Roth

Resolution: fixed
Status: assignedclosed

Also tested GameControllerDevice?. Works fine.

Note: See TracTickets for help on using tickets.